fix(line): keep labels above lines. close #15679#21682
Open
rahul37wallst-sudo wants to merge 1 commit into
Open
fix(line): keep labels above lines. close #15679#21682rahul37wallst-sudo wants to merge 1 commit into
rahul37wallst-sudo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Keeps line series paths below labels from mixed series by lowering the default line polyline
z2.Fixed issues
Details
Before: What was the problem?
In mixed charts such as bar + line, the line polyline used a default
z2of10.That made the line path render above labels attached to other series, so a line series could visually overlap bar labels.
After: How does it behave after the fixing?
The line polyline default
z2is lowered to1, so it no longer sits above labels from other series.A regression test was added to verify that a line polyline is rendered below a bar label in a mixed bar + line chart.
Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
test/ut/spec/series/line.test.tsValidation run:
npx jest --config test/ut/jest.config.cjs --coverage=false --runInBand --runTestsByPath test/ut/spec/series/line.test.tsnpm run lintnpm run checktypenpx eslint test/ut/spec/series/line.test.tsgit --no-pager diff --checkMerging options
Other information
N.A.